Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peering status handling in network peering reconciler #1064

Merged
merged 1 commit into from
May 14, 2024
Merged

Remove peering status handling in network peering reconciler #1064

merged 1 commit into from
May 14, 2024

Conversation

kasabe28
Copy link
Contributor

@kasabe28 kasabe28 commented May 8, 2024

Proposed Changes

  • Add networkpeering controller in list of controllers in main
  • Remove network peering status update from network peering controller as its been handled by apinetlet
  • Modify network peering tests accordingly

@kasabe28 kasabe28 requested a review from a team as a code owner May 8, 2024 10:42
@github-actions github-actions bot added size/L bug Something isn't working labels May 8, 2024
@kasabe28 kasabe28 self-assigned this May 9, 2024
@afritzler afritzler changed the title Fix network peering controller Remove peering status handling in network peering reconciler May 14, 2024
@afritzler afritzler added enhancement New feature or request and removed bug Something isn't working labels May 14, 2024
@afritzler afritzler merged commit 51392fa into main May 14, 2024
23 checks passed
@afritzler afritzler deleted the fix/network-peering branch May 14, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees

@kasabe28 kasabe28

Labels
enhancement New feature or request size/L
Projects
Core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasabe28 @afritzler