Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: space in shebang path for windows #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gucong3000
Copy link

@gucong3000 gucong3000 commented Sep 30, 2018

Closes: #70

@gucong3000
Copy link
Author

gucong3000 commented Sep 30, 2018

It would be nice to have Appveyor failing due to the bug.

@demurgos https://ci.appveyor.com/project/isaacs/spawn-wrap/build/133

@gucong3000 gucong3000 changed the title [WIP]fix: space in shebang path for windows fix: space in shebang path for windows Sep 30, 2018
@demurgos
Copy link
Contributor

@gucong3000 Thanks! I don't have write access here but I'll look into your changes and it to my branch. (spawn wrap is being slowly phased out).

@demurgos
Copy link
Contributor

demurgos commented Oct 9, 2018

I started merging my fork into the main lib (#77, #78, and probably a few more in the upcoming days). I'll make sure to rebase your fix on top of it.

@AustonZ
Copy link

AustonZ commented Jan 25, 2019

Any update here? This has been blocking me from using the 'nyc' code coverage package on Windows for months now.

@demurgos
Copy link
Contributor

Hi,
Here is an update of the situation:

The library got migrated from the tapjs org to istanbuljs to bring new maintainers. It is planned to release a new major version of spawn-wrap and address some of the long standing issues. You may have noticed a recent increase in activity, that's the reason.

Regarding this particular issue, we are looking into it and would like to address it. The fix looks simple but I am not a Windows expert, nor @coreyfarrell. This is probably why it is not merged already: we want to understand the impact of the PR and if there's a risk of breaking something. For example, I am worried about how it interacts witch cross-spawn and would like to test it before.

Also, thank you very much for the repro in #70 (comment), it helps greatly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants