Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning notes if helm charts Istio version is already EOL #1294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zufardhiyaulhaq
Copy link
Member

Signed-off-by: zufardhiyaulhaq [email protected]

fix istio/istio#41747, introduce a warning if the current date is near or after EOL of the date defined in the release builder.

image

@zufardhiyaulhaq zufardhiyaulhaq requested a review from a team as a code owner December 7, 2022 15:19
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2022
@zufardhiyaulhaq
Copy link
Member Author

cc @howardjohn

@@ -160,6 +163,9 @@ type Manifest struct {
Dependencies IstioDependencies `json:"dependencies"`
// Version specifies what version of Istio this release is
Version string `json:"version"`
// EOLDate specifies what is the date when this Istio version become EOL
// Should be in format "yyyy-mm"
EOLDate string `json:"eolDate"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we already have to update istioctl binary directly it seems like we could just update the helm notes directly as well? We can have a test to check they are in sync if needed

Will defer to @ericvn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean to update the helm notes directly on istio/istio repository?

Signed-off-by: zufardhiyaulhaq <[email protected]>
@zufardhiyaulhaq
Copy link
Member Author

@ericvn can you help here?

@zufardhiyaulhaq
Copy link
Member Author

cc @istio/wg-test-and-release-maintainers please help review

@kfaseela
Copy link
Member

cc @jacob-delgado

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 23, 2024
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on istioctl install when the version is EOL
4 participants