fix(C.SC.2.2): add AGID unreachable check

italia · May 31, 2024 · 590c279 · 590c279
1 parent 36b121f
commit 590c279
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/audits/municipality/accessibilityDeclarationIsPresentAudit.ts b/src/audits/municipality/accessibilityDeclarationIsPresentAudit.ts
@@ -5,6 +5,7 @@ import { CheerioAPI } from "cheerio";
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import lighthouse from "lighthouse";
+
 import { getAllPageHTML, loadPageData, urlExists } from "../../utils/utils";
 import { auditDictionary } from "../../storage/auditDictionary";
 
@@ -78,6 +79,7 @@ class LoadAudit extends Audit {
     ];
 
     const $: CheerioAPI = await loadPageData(url);
+
     const accessibilityDeclarationElement = $("footer").find(
       '[data-element="accessibility-link"]'
     );

diff --git a/src/audits/school/accessibilityDeclarationIsPresentAudit.ts b/src/audits/school/accessibilityDeclarationIsPresentAudit.ts
@@ -14,9 +14,6 @@ const Audit = lighthouse.Audit;
 const auditId = "school-legislation-accessibility-declaration-is-present";
 const auditData = auditDictionary[auditId];
 
-const greenResult = auditData.greenResult;
-const redResult = auditData.redResult;
-
 class LoadAudit extends Audit {
   static get meta() {
     return {
@@ -72,7 +69,7 @@ class LoadAudit extends Audit {
 
     const items = [
       {
-        result: redResult,
+        result: auditData.redResult,
         link_name: "",
         link_destination: "",
         existing_page: "No",
@@ -98,6 +95,10 @@ class LoadAudit extends Audit {
     ) {
       const href = elementObj.href;
       const checkUrl = await urlExists(url, href);
+
+      if (checkUrl.exception)
+        throw new Error("Possibile errore del server AGID, verificare.");
+
       if (!checkUrl.result) {
         return {
           score: 0,
@@ -137,7 +138,7 @@ class LoadAudit extends Audit {
         items[0].wcag = "Sì";
       }
 
-      items[0].result = greenResult;
+      items[0].result = auditData.greenResult;
       score = 1;
     }