Draft: Some changes #15
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nicolasvac, as of today this package passess all the tests in spid-saml-check but some things that seem to be in your branch are not implemented such as aggregators. I'll leave this PR open in case anyone wants to submit a mergeable PR for the missing parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @alranel ,
i have received a notification today that the package has seen some activity.
I don't remember exactly what i've done, but i remember there were some missing elements and signings.
i opened this MR only as a reference in case you want to implement some of the changes.
In case you dont need this, feel free to close it.
Thanks,
Nicolas.