Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document title #352

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Document title #352

wants to merge 12 commits into from

Conversation

DanielSteger
Copy link
Contributor

No description provided.

@DanielSteger DanielSteger linked an issue Jun 24, 2020 that may be closed by this pull request
import {TitleService} from './title.service';
import {SharedMocksModule} from '../testing/shared-mocks.module';

describe('TitleService', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests or remove

@BennyLi
Copy link
Contributor

BennyLi commented Sep 1, 2020

There is another thing I like to put into discussion while seeing this in action:

Some page titles doesn't make much sense to me (like Home, Overview, Summary). Maybe a prefix could add some context here? Example: OSM - Home

What do you think?
Maybe some others have thoughts about this too @nilskuhn @j0weiss @sburnicki ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document title
2 participants