Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL as permalink for angular charts #353

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

URL as permalink for angular charts #353

wants to merge 5 commits into from

Conversation

DanielSteger
Copy link
Contributor

No description provided.

@DanielSteger DanielSteger linked an issue Jun 24, 2020 that may be closed by this pull request
URL as permalink #339
Open
BennyLi
BennyLi suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@BennyLi BennyLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one issue while testing this.

If you paste a url and remove parts from it, the page will show the spinner and the error nearby the Show button. It would be nice to hide the spinner in this case.

Example URL:
http://localhost:8080/eventResultDashboardDev/showAll?from=2020-08-03T22:00:00.000Z&to=2020-09-01T21:59:00.000Z&selectedFolder=118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BennyLi BennyLi BennyLi requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL as permalink
2 participants
@DanielSteger @BennyLi