Skip to content

Commit

Permalink
Remove assertion that isn't always valid
Browse files Browse the repository at this point in the history
This is specifically not valid when the return value is implicitly
truncated.
  • Loading branch information
jacobly0 committed Nov 6, 2023
1 parent b756a0b commit efc2b24
Showing 1 changed file with 10 additions and 8 deletions.
18 changes: 10 additions & 8 deletions llvm/lib/Target/Z80/Z80MachineEarlyOptimization.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,15 +102,17 @@ bool Z80MachineEarlyOptimization::runOnMachineFunction(MachineFunction &MF) {
break;
}
if (CallMI && Opc == TargetOpcode::COPY) {
if (Results.size() == 4) {
CallMI = nullptr;
break;
Register DstReg = I->getOperand(0).getReg();
Register SrcReg = I->getOperand(1).getReg();
if (DstReg.isVirtual() && SrcReg.isPhysical()) {
if (Results.size() == 4) {
CallMI = nullptr;
break;
}
Result &Res = Results.emplace_back();
Res.TrueReg = DstReg;
Res.PhysReg = SrcReg;
}
Result &Res = Results.emplace_back();
Res.TrueReg = I->getOperand(0).getReg();
Res.PhysReg = I->getOperand(1).getReg();
assert(Res.TrueReg.isVirtual() && Res.PhysReg.isPhysical() &&
"Expected phys to virt reg copy inside call sequence");
}
}
for (I = FalseMBB->begin(), E = FalseMBB->end(); CallMI && I != E && I->isPHI();
Expand Down

0 comments on commit efc2b24

Please sign in to comment.