Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package json and delete node_modules #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add package json and delete node_modules #12

wants to merge 1 commit into from

Conversation

weeska
Copy link

@weeska weeska commented Dec 21, 2017

Hi there.

I thought it would be more straight-forward to have a package.json describing the project's dependencies. I don't know if you're familiar with node.js, but this way you can just type npm install and it installs all dependencies - no need to push them.

Things that I've changed:

  • use npm init to create a package.json
  • Delete node_modules folder
  • add .gitignore

@bkmeneguello
Copy link

Not all dependencies are resolved yet, hum? It's not possible to use as node dependency.
I think core could be split as standalone library.

@s123121
Copy link

s123121 commented Dec 22, 2017

This need to be done ASAP because no professional developers would commit node_modules into git. This will more or less affect the RaiWallet credibility

@weeska
Copy link
Author

weeska commented Dec 22, 2017

@bkmeneguello npm init automatically writes packages from the node_modules folder into the generated package.json. So all dependencies should be resolved. I also removed the nacl folder as it did not seem to be used.

I wonder if there is some sort of CI system. It's hard to see what's effected by changes.

@jaimehgb
Copy link
Owner

Hmm @chriscohoat did the same here:
#5

He also moved Wallet.js and Block.js (the wallet itself) into a new and self-contained repo:
https://github.com/chriscohoat/rai-wallet

I think that's the way to do it, still have to test his branch though (cough)
:)

@weeska
Copy link
Author

weeska commented Dec 30, 2017

I'm fine with closing this one if the PR of @chriscohoatgets gets merged. Either way there is some work to be done to enable other developers to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants