Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: fix return value of janus-idp.hostname #116

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Sep 29, 2023

Description of the change

Fixed the helm chart's helper template so that the janus-idp.hostname returns the correct value that matches the route host when the clusterRouterBase is defined.

Existing or Associated Issue(s)

Fixes #97

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@Zaperex Zaperex requested a review from a team as a code owner September 29, 2023 21:15
@Zaperex Zaperex requested a review from a team September 29, 2023 21:15
@Zaperex
Copy link
Member Author

Zaperex commented Sep 29, 2023

I think the CI tests are failing since the helm chart is currently pulling the quay.io/janus-idp/backstage-showcase:latest which currently doesn't work with the default configurations.

This is most likely by the test-connection pod is unable to get a response from the backstage deployment pod since the pod has already stopped due to the backend failing to start up.

@Zaperex
Copy link
Member Author

Zaperex commented Sep 29, 2023

I ran the ct install --config ct-install.yaml test locally on Openshift Local after changing the image in the values.yaml to quay.io/janus-idp/backstage-showcase:nightly-20230929 and it passed.

@kadel
Copy link
Member

kadel commented Oct 4, 2023

@Zaperex If you rebase with the current main branch, it should fix the testing issue.

Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit 93957f6 into janus-idp:main Oct 11, 2023
2 checks passed
@Zaperex Zaperex deleted the update-helper-templates branch October 11, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: janus-idp.hostname is not returning correct value
3 participants