-
Notifications
You must be signed in to change notification settings - Fork 54
feat: add fallback value for janus-idp.hostname for openshift clusters #169
feat: add fallback value for janus-idp.hostname for openshift clusters #169
Conversation
Thank you @Zaperex |
@Zaperex any updates for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing: the default value for global.clusterRouterBase
is apps.example.com
, which means that if I want to use this new feature, I need to explicitly set it to an empty string in my values.yaml
file, right?
Would it make sense to set the default value to an empty string instead, so that most users won´t even need to think about this? On OpenShift, without having to set global.clusterRouterBase
, I would get the right hostname value.
b0a55e5
to
a41f134
Compare
a41f134
to
c53489e
Compare
whoops it seems the test charts github action isn't running in an openshift cluster, which is why it's failing with the new default value for |
b121663
to
2317a4f
Compare
2317a4f
to
3f74af9
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of the change
Adds a fallback value for
janus-idp.hostname
for openshift clusters when bothglobal.host
andglobal.clusterRouterBase
are not provided.Existing or Associated Issue(s)
Fixes #167
Additional Information
Checklist
Chart.yaml
according to semver.values.yaml
and added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -a
to apply changes.pre-commit
hook.ct lint
command.