Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first draft to use the joomla core module techniques #1813

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reilldesign
Copy link

To be able to select mod_jem overrides (layouts) via dropdown.

Change of entity names to get a more elegant navigation control for the calendar.
in layout com_jem view-event

the icon buttons (.buttons) are not clickable and masked by h1.componentheading
To be able to select mod_jem overrides  (layouts) via dropdown.
@mckillo
Copy link
Collaborator

mckillo commented Aug 21, 2024

In the lastest version 4.2.3 (dev in github):

  • The calendar icons (navigation controls) were changed to Font Awesome icons.
  • The issue with the masked icon couldn't be reproduced, and this commit adds a unnecessary line (space on top).
  • A draft to improve the layout in modules could be addressed by module override,

On the last point, there is a lot of code improvement in JEM, so this should be kept in mind for future versions and JEM should be updated to support the Joomla 6 core and to facilitate the creation of new layouts in JEM (low priority).

@reilldesign
Copy link
Author

An override is indeed possible. But how can I create different overrides if I can't choose the layout?

@mckillo
Copy link
Collaborator

mckillo commented Aug 21, 2024

I agree. If you need more layouts, an override will be a solution if you want to modify one of them (default, responsive).

Please provide a description of a real case and an example of a layout, so we can evaluate it. Thank you for your expertise and ideas to improve JEM.

The layout is defined as a global setting, and the component and modules display the style based on this setting. Currently, JEM has two layouts and could potentially have more, but adding them would require further code changes.

I have tested the necessary changes and can create new layouts for the JEM modules, but I still need to finish testing.

@reilldesign
Copy link
Author

Joomla Overrides are a very powerful way to change design and functions. I currently use a mod_jem override to pass event dates to a form (booking). For me it is not important that there are different layouts in the core, but that I can make full use of the override possibilities that the Joomla core provides. The core should only have a clean responsive layout to simplify maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants