Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jenkins.get() instead of deprecated method and minor improvements #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefanSpieker
Copy link

@StefanSpieker StefanSpieker commented Oct 2, 2023

Use Jenkins.get() instead of deprecated method and minor improvements:

  • Use StandardCharsets.UTF_8
  • removed unused imports

Testing done

All tests passed. Jenkins came up normally in debug environment.

Submitter checklist

@halkeye
Copy link
Member

halkeye commented Oct 2, 2023

Do you know when get was added? Is it newer than the base version in the pom?

@StefanSpieker
Copy link
Author

Since 2.98 Jenkins.java which is a lot older than 2.235.5

@halkeye
Copy link
Member

halkeye commented Oct 2, 2023

Oh wow I updated it to 2.x at some point. I thought it was still in the 1s. Okay I'll take a poke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants