[JENKINS-74858] Added validation for Password length in FIPS mode #9995

tejasdrolia · 2024-11-20T07:22:09Z

Made changes to ensure that an exisiting user is now unable to alter the password to less than 14 characters in length when operating in FIPS mode.

Testing done

Automated Unit Testing
Implemented unit tests to verify FIPS compliance for password changes:

Ensured that passwords shorter than 14 characters are rejected when FIPS mode is enabled.
Verified that mismatched passwords between user.password and user.password2 trigger appropriate errors.

Manual Testing
Did Manual testing to verify my changes to ensure that everything is working properly.

Without FIPS mode: Shorter password is being accepted.

With FIPS mode: Shorter password is not being accepted.

Proposed changelog entries

Added Password validation to ensure that existing users cannot create a password of less than 14 characters in length(when in FIPS mode).

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

welcome · 2024-11-20T07:22:13Z

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java

daniel-beck

Would be nice if newly added tests covered the success case (long + matching password) in addition to not relying on mocks.

daniel-beck · 2024-11-20T09:11:03Z

test/src/test/java/hudson/security/HudsonPrivateSecurityRealmFIPSTest.java

+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;


This looks like unnecessary use of mocks, prefer WebClient.

Fixed in recent commit

fcojfernandez

You have spotless issues, just execute mvn clean install -DskipTests to see and fix them

(haven't see them clearly in the CI logs, but they seem to be related to my comments about the empty line and the wildcard)

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java

fcojfernandez · 2024-11-20T15:20:14Z

test/src/test/java/hudson/security/HudsonPrivateSecurityRealmFIPSTest.java

-import static org.hamcrest.Matchers.is;
-import static org.hamcrest.Matchers.not;
-import static org.hamcrest.Matchers.startsWith;
+import static org.hamcrest.Matchers.*;


Do not use wildcards in the imports. Add as many imports as you need

fcojfernandez · 2024-11-20T15:22:07Z

test/src/test/java/hudson/security/HudsonPrivateSecurityRealmFIPSTest.java

 import static org.junit.Assert.assertThrows;
-


Don't change the format of the file, please. Revert the deletion. This together with the wildcard makes me think you should review your IDE settings

test/src/test/java/hudson/security/HudsonPrivateSecurityRealmFIPSTest.java

fcojfernandez · 2024-11-20T15:59:19Z

test/src/test/java/hudson/security/HudsonPrivateSecurityRealmFIPSTest.java

+        HtmlForm form = configurePage.getFormByName("config");
+        assertThrows(FailingHttpStatusCodeException.class, () -> {
+            j.submit(form);
+        });


See the userLoginAfterEnablingFIPS method above in this test class. Probably you should check the log message as well. That method is doing

assertThat(getLogRecords(), hasItem(incorrectHashingLogEntry()));

Apparently , there are no logs events during the test execution.

BEE-51743 | Added validation for Password length in FIPS mode

93d34e3

PereBueno reviewed Nov 20, 2024

View reviewed changes

core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java Outdated Show resolved Hide resolved

daniel-beck reviewed Nov 20, 2024

View reviewed changes

BEE-51743 | Resolved comments

afe7d25

fcojfernandez reviewed Nov 20, 2024

View reviewed changes

[JENKINS-74858] resolved some comments

7cfca70

tejasdrolia changed the title ~~JENKINS-74858 | Added validation for Password length in FIPS mode~~ [JENKINS-74858] Added validation for Password length in FIPS mode Nov 20, 2024

Merge branch 'master' into BEE-51743

39171ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JENKINS-74858] Added validation for Password length in FIPS mode #9995

[JENKINS-74858] Added validation for Password length in FIPS mode #9995

tejasdrolia commented Nov 20, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

welcome bot commented Nov 20, 2024

daniel-beck left a comment

daniel-beck Nov 20, 2024

tejasdrolia Nov 20, 2024

fcojfernandez left a comment

fcojfernandez Nov 20, 2024

fcojfernandez Nov 20, 2024

fcojfernandez Nov 20, 2024

tejasdrolia Nov 21, 2024

		import static org.mockito.Mockito.mock;
		import static org.mockito.Mockito.when;

[JENKINS-74858] Added validation for Password length in FIPS mode #9995

Are you sure you want to change the base?

[JENKINS-74858] Added validation for Password length in FIPS mode #9995

Conversation

tejasdrolia commented Nov 20, 2024 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

welcome bot commented Nov 20, 2024

daniel-beck left a comment

Choose a reason for hiding this comment

daniel-beck Nov 20, 2024

Choose a reason for hiding this comment

tejasdrolia Nov 20, 2024

Choose a reason for hiding this comment

fcojfernandez left a comment

Choose a reason for hiding this comment

fcojfernandez Nov 20, 2024

Choose a reason for hiding this comment

fcojfernandez Nov 20, 2024

Choose a reason for hiding this comment

fcojfernandez Nov 20, 2024

Choose a reason for hiding this comment

tejasdrolia Nov 21, 2024

Choose a reason for hiding this comment

tejasdrolia commented Nov 20, 2024 •

edited

Loading