Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Std.is to Std.isOfType, bumped hscript to 2.4.0 #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qeshi
Copy link

@qeshi qeshi commented Aug 29, 2022

Hi!

I changed the Std.is to Std.isOfType to remove the deprecated warnings.
I also bumped hscript to 2.5.0

@jeremyfa
Copy link
Owner

Thanks! I see that at some places you updated hscript to 2.5.0 instead of 2.4.0. Any reason for that?

@qeshi
Copy link
Author

qeshi commented Aug 29, 2022

Ah, that is wrong.
It should be the same version everywhere.

But what version should be used, 2.5.0 or 2.4.0?

@qeshi qeshi changed the title Changed Std.is to Std.isOfType, bumped hscript to 2.5.0 Changed Std.is to Std.isOfType, bumped hscript to 2.4.0 Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants