forked from KhronosGroup/Vulkan-ValidationLayers
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gpu: Check index buffer contents in pre-draw validation
This involves splitting up draw.vert into separate shaders for non-indexed indirect, indexed (both indirect and direct) and mesh draw calls. Fixes KhronosGroup#2492
- Loading branch information
1 parent
fb1d091
commit 366871b
Showing
28 changed files
with
1,915 additions
and
603 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Copyright (c) 2021-2024 The Khronos Group Inc. | ||
| // Copyright (c) 2021-2024 Valve Corporation | ||
| // Copyright (c) 2021-2024 LunarG, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Values used between the GLSL shaders and the GPU-AV logic | ||
|
|
||
| // NOTE: This header is included by the instrumentation shaders and glslang doesn't support #pragma once | ||
| #ifndef GPU_SHADERS_DRAW_PUSH_DATA_H | ||
| #define GPU_SHADERS_DRAW_PUSH_DATA_H | ||
|
|
||
| #ifdef __cplusplus | ||
| namespace gpuav { | ||
| namespace glsl { | ||
| using uint = unsigned int; | ||
| #endif | ||
|
|
||
| // Bindings for all pre draw types | ||
| const uint kPreDrawIndirectBinding = 0; | ||
| const uint kPreDrawCountBinding = 1; | ||
| const uint kPreDrawIndexBinding = 2; | ||
|
|
||
| // Flag values for all pre draw types | ||
|
|
||
| // Set if the count buffer is bound | ||
| const uint kPreDrawSelectCountBuffer = (1 << 0); | ||
| // Set if the draw buffer is bound | ||
| const uint kPreDrawSelectDrawBuffer = (1 << 1); | ||
| // Set if firstInstance fields of draw structs must be validated | ||
| const uint kPreDrawSelectFirstInstance = (1 << 2); | ||
| // Set if the index buffer is bound | ||
| const uint kPreDrawSelectIndexBuffer = (1 << 3); | ||
|
|
||
| struct DrawIndirectPushData { | ||
| uint flags; | ||
| uint prop_count_limit; | ||
| uint buffer_count_limit; | ||
| uint draw_count; | ||
| uint draw_stride; | ||
| }; | ||
|
|
||
| struct DrawIndexedPushData { | ||
| uint flags; | ||
| uint prop_count_limit; | ||
| uint buffer_count_limit; | ||
| uint draw_count; | ||
| uint draw_stride; | ||
| uint first_index; | ||
| uint index_count; | ||
| uint index_width; | ||
| uint vertex_offset; | ||
| uint vertex_buffer_size; | ||
| }; | ||
|
|
||
| struct DrawMeshPushData { | ||
| uint flags; | ||
| uint prop_count_limit; | ||
| uint buffer_count_limit; | ||
| uint draw_count; | ||
| uint draw_stride; | ||
| uint max_workgroup_count_x; | ||
| uint max_workgroup_count_y; | ||
| uint max_workgroup_count_z; | ||
| uint max_workgroup_total_count; | ||
| }; | ||
|
|
||
| #ifdef __cplusplus | ||
| } // namespace glsl | ||
| } // namespace gpuav | ||
| #endif | ||
| #endif |
Oops, something went wrong.