Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak dynamic parameters #259

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Tweak dynamic parameters #259

merged 8 commits into from
Sep 6, 2024

Conversation

jeromekelleher
Copy link
Owner

@jeromekelleher jeromekelleher commented Sep 5, 2024

Trying out running in three passes with a likelihood threshold of 0, mu, and rho^2 * mu^5 (which is about 1e-10, and around the same as 10 mutations). I've arbitrarily chosen this as the most unlikely thing we'd want to characterise exactly.

Just seeing if this gives us the same results as the previous pass with completely unlimited precision and improves run-time.

@jeromekelleher
Copy link
Owner Author

One oddity here is that we seem to be sometimes choosing a 3 mutations over a recombination. Eg for ERR4209451 we are choosing three recurrent mutations over a recombination.

Final HMM pass hmm_cost=3.0 ERR4209451 2020-03-10 B path=(0:29904, 194) mutations(3)=1397A>G,14805C>T,17659G>T]

This is done at full precision, so I'm not sure what's going on.

@jeromekelleher
Copy link
Owner Author

Solving the above problem required going back to first principles, and I think I've got the right expression for solving num_mismatches. We seem to be reliably choosing recombinants now rather than 3 mutations. There's a bunch of other stuff gone in now too.

@jeromekelleher
Copy link
Owner Author

Merging this and running a "long ARG" based on it over weekend. Let's see how it goes.

@jeromekelleher jeromekelleher merged commit 220862e into main Sep 6, 2024
2 of 3 checks passed
@jeromekelleher jeromekelleher deleted the dynamic-precision-tweaks branch September 9, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant