Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates RStudio shutdown and pause for new layout #211

Merged
merged 6 commits into from
Jul 13, 2023

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Jun 27, 2023

Changes:

This is a much needed update that will also be borrowed for fhdsl/AnVIL_Demos#21 .

Hopefully this doesn't overlap too much with #206

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

The check: broken urls is currently being re-run 🏃
Comment updated at 2023-07-13 with changes from c93848a

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

The check: spelling errors is currently being re-run 🏃
Comment updated at 2023-07-13 with changes from c93848a

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Re-rendered previews from the latest commit:

Updated at 2023-06-27 with changes from cf46f26

Copy link
Collaborator

@KatherineCox KatherineCox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When working on #206, I noticed that if my window wasn't expanded to the full width of my screen, the cloud environment icons get pushed off the page, so I suggested adding a comment about it.

Otherwise, LGTM!

I thought #206 was going to be a quick update, but then I got off into the weeds of trying to explain persistent disks and when you might want to keep/delete them... I'll circle back to that when I get a chance, and probably close #206 and start a new PR. In the meantime, it's great to have these instructions updated with the changes to the UI, thanks!

child/_child_rstudio_delete.Rmd Outdated Show resolved Hide resolved
child/_child_rstudio_pause.Rmd Outdated Show resolved Hide resolved
@avahoffman avahoffman merged commit c40558a into main Jul 13, 2023
@avahoffman avahoffman deleted the ava/rstudio-shutdown-revised branch July 13, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants