Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ckeditor gem to work properly with Rails 4+ asset pipeline #227

Merged
merged 1 commit into from
Jan 31, 2015

Conversation

dept42
Copy link
Contributor

@dept42 dept42 commented Dec 13, 2014

This is very minimally tested so far, but seems to have solved my problem.

@dept42
Copy link
Contributor Author

dept42 commented Dec 13, 2014

This is related to issue #199

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8fd3515 on dept42:ckeditor_upgrade into 0ef9ed3 on jipiboily:master.

@msevestre
Copy link
Collaborator

Interesting... can you deploy to production without having to copy some
assets manually? Can you confirm?

On Fri, Dec 12, 2014 at 10:03 PM, Coveralls [email protected]
wrote:

[image: Coverage Status] https://coveralls.io/builds/1605762

Coverage remained the same when pulling 8fd3515
8fd3515
on dept42:ckeditor_upgrade
into 0ef9ed3
0ef9ed3
on jipiboily:master
.


Reply to this email directly or view it on GitHub
#227 (comment).

@dept42
Copy link
Contributor Author

dept42 commented Dec 14, 2014

Yeah, with Rails 4.1.5 in a pretty default deployment on Ninefold, this change makes the icons appear in production where before they were absent.

@msevestre
Copy link
Collaborator

That's awesome. Great contribution
On Dec 13, 2014 10:01 PM, "Chris Williams" [email protected] wrote:

Yeah, with Rails 4.1.5 in a pretty default deployment on Ninefold, this
change makes the icons appear in production where before they were absent.


Reply to this email directly or view it on GitHub
#227 (comment).

msevestre pushed a commit that referenced this pull request Jan 31, 2015
Upgrade ckeditor gem to work properly with Rails 4+ asset pipeline
@msevestre msevestre merged commit 959c1ab into jipiboily:master Jan 31, 2015
@msevestre
Copy link
Collaborator

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants