upgrade all the things (upgrade to Rails 5) #301
Conversation
|
Let's merge this! Some of my builds fail due to some of the older Ruby versions problems. |
|
@illegalnumbers yeah, not that I don't want to but I was not able to figure it out when I looked briefly last week. Any idea maybe? I can look a bit later. |
|
Honestly I really wasn't even able to get the test suite up and running locally since it's dependencies are so out of date...it might just be worth it to merge this guy in to get the builds to build the right Ruby versions and then just update the other libraries and fix tests on an as needed basis. |
|
Time to move on indeed :) |
|
Going to work on this shortly. |
|
ok, this isn't going to be trivial. We need a full upgrade, and it hasn't happened in a while. There are a lot of deprecations, which we can live with for a few weeks/months until Rails 5.1 is out. That said, I can't get the tests running locally at all. I removed some gems, upgraded others, still not working. Issues are with the Capybara tests (surprise! This is brittle!). If someone wants to make Monologue Rails 5.0 compatible and ideally 5.1 ready, get in touch please. I can pay $100. It's not a lot, but it's open source and I don't even use it myself anymore 😀 |
jipiboily
changed the title
|
Closing in favor of #314 |
No description provided.