python>=3.8 func_inspect: allow POSITIONAL_ONLY parameters #1313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables correct caching for functions with positional-only arguments. This breaks compatibility with python3.7. As soon as python3.7 support is replaced by python>=3.8, this can be merged.
Positional only parameters (added in python3.8) are not hashed. This is due to filter_args which handles POSITIONAL_OR_KEYWORD parameters but ignores POSITIONAL_ONLY parameters. Since hashing uses a name-value tuple list, it is possible to treat POSITIONAL_ONLY equivalently to POSITIONAL_OR_KEYWORD parameters.