Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix desktop switching on dvorak layouts #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix desktop switching on dvorak layouts #481

wants to merge 1 commit into from

Conversation

laserbat
Copy link

@laserbat laserbat commented Jan 24, 2019

Binding

<Key mask="A" key="#">desktop#</Key>

doesn't work correctly on some dvorak layouts, namely programmers dvorak and classic dvorak, since on these layouts keys that are typically number keys are used for other purpose and have different keysyms.

To work around this issue this patch uses keycodes (which are consistent between layouts) to get the correct keysym.

@rdnvndr
Copy link
Contributor

rdnvndr commented Jan 25, 2019

Do other hot keys work correctly in the dvorak layout?
For example:

<Key mask="CA" key="t">exec:xterm </Key>

@laserbat
Copy link
Author

Yes, other hotkeys work as they should.

@rdnvndr
Copy link
Contributor

rdnvndr commented Jan 26, 2019

I think the problem not in JWM (without patch). I run command:

setxkbmap -v us -variant dvorak

Changing the desktop works. I using Archlinux.

@laserbat
Copy link
Author

As I've said, problem is with classic and progremmer's dvorak variants. The problem arises because of non-standard layout of number keys: https://www.kaufmann.no/roland/dvorak/images/dvp1.png

Try this

setxkbmap -layout us -variant dvp

@rdnvndr
Copy link
Contributor

rdnvndr commented Jan 26, 2019

I exec JWM by commands:

setxkbmap -layout us -variant dvp
jwm

I press the key CAPSLOCK
I press the keys ALT + 3

The desktop is changing

@laserbat
Copy link
Author

Yes, this works, but it's inconvenient to have to use caps lock to switch desktops.

@rdnvndr
Copy link
Contributor

rdnvndr commented Jan 27, 2019

It works for me without CAPSLOCK. I suggested that you have a problem with this.

PS: I also use a xorg-server 1.20.3 with a patch https://aur.archlinux.org/packages/xorg-server-bug865. Perhaps this will help when looking for a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants