Alt+RightClick: Resize appropiate corner depending on cursor position in window #492
Conversation
|
No interest? |
|
I asked for this feature from a while now, but apparently this is not their priority. I think i will try your commit... |
|
its really amazing! |
| @@ -371,7 +382,7 @@ void ResizeClientKeyboard(ClientNode *np, MouseContextType context) | |||
| DiscardMotionEvents(&event, np->window); | |||
|
|
|||
| UpdateSize(np, context, event.xmotion.x, event.xmotion.y, | |||
| startx, starty, oldx, oldy, oldw, oldh); | |||
| startx, starty, oldx, oldy, oldw, oldh, 0); | |||
There was a problem hiding this comment.
It seems to me that either UpdateSize needs to check for the case that prevContext is NULL or this should pass a valid pointer into UpdateSize?
There was a problem hiding this comment.
You mean passing something else instead of 0?
There was a problem hiding this comment.
0 turns into a null pointer dereference in UpdateSize, which leads to a seg fault for me when I select resize from the window menu. I think passing &context might give the desired effect.
There was a problem hiding this comment.
I see. As I said, I'm definitely not an expert at C so feel free to modify the code as you see fit.
As discussed here.
PS. I'm not an expert at C so I hope this doesn't break anything or produce memleaks. :)