Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the stack is up and running when running castor up #317

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jul 23, 2024

No description provided.

@jeromegxj
Copy link

Shouldn't we update docker-compose.yml with:

    frontend:
        build:
            context: services/php
            target: frontend
        depends_on:
            postgres:
                condition: service_healthy

WDYT?

@lyrixx
Copy link
Member Author

lyrixx commented Jul 23, 2024

Totally, I fix that

@lyrixx lyrixx merged commit 2e62d45 into main Jul 24, 2024
4 checks passed
@lyrixx lyrixx deleted the optimize-ci branch July 24, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants