Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options.priority ternary in serialize validation #207

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

jonchurch
Copy link
Member

closes #206

Assuming here this was not intentional

@jonchurch
Copy link
Member Author

jonchurch commented Nov 15, 2024

Im guessing Codecov is failing bc I opened from a fork, so no access to the secret

@blakeembrey
Copy link
Member

Good catch, do you want to make both undefined in the ternaries? I don’t know why I didn’t do that the first time.

@jonchurch
Copy link
Member Author

By both you mean the next block w/

  if (options.sameSite) {
    const sameSite =
      typeof options.sameSite === "string"
        ? options.sameSite.toLowerCase()
        : options.sameSite;

this needs to stay, at that part of the code sameSite can be boolean | <the valid strings>

@blakeembrey blakeembrey merged commit 4898ba2 into jshttp:master Nov 15, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the purpose of the options.sameSite branch of ternary in serialize?
2 participants