Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These IRI normalization tests directly correspond to those for #395

Merged
merged 2 commits into from
Oct 4, 2016

Conversation

gkellogg
Copy link
Member

@gkellogg
Copy link
Member Author

@dlongley @lanthaler @ansell @sblom: You might check your implementations against these before we merge the PR. See w3c/rdf-tests#6 for more detail, but the logic should be the same for all RDF serialization formats.

@RubenVerborgh
Copy link

We should perhaps not merge before the discussion on w3c/rdf-tests#6 has ended. Some of the tests are still up for debate (their correctness is not questioned, only whether all cases need to be included).

@gkellogg
Copy link
Member Author

Makes sense. Still, it would be good to see where other implementations are.

@dlongley
Copy link
Member

@gkellogg,

I haven't had a chance to take a look yet -- it's a very busy week. Will try to get to it when I can.

@ansell
Copy link

ansell commented Oct 22, 2015

@gkellogg Hi, sorry, I have been at a conference so far this week and won't have a chance to look at this until next week at the earliest. I have been following the relative IRI discussions on the mailing lists, but have not yet tested them with JSONLD-Java or Sesame.

@lanthaler
Copy link
Member

Sorry for the delay from my side as well. I’ve just tested the new test cases. My implementation passes all of them out of the box.

@gkellogg
Copy link
Member Author

gkellogg commented Nov 7, 2015

Great! Based on discussion on the Turtle side (see w3c/rdf-tests/issues/6 and w3c/rdf-tests/pull/13), we'll probably reduce the normative checks a bit further. I'll just wait for that to resolve.

@gkellogg gkellogg merged commit 55377aa into master Oct 4, 2016
@gkellogg gkellogg deleted the issue-394-IRI-resolution-tests branch October 4, 2016 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants