add emomatching task to piop2 datagrabber #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeSasse
commented
Oct 1, 2024
LeSasse
commented
- fix [BUG]: AOMIC PIOP2 missing tasks #370
- description of feature/fix
- tests added/passed
- add an entry for the latest changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 93 93
Lines 5067 5067
Branches 1031 1031
=======================================
Hits 4475 4475
Misses 426 426
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fraimondo
requested changes
Oct 1, 2024
docs/whats_new.rst
Outdated
| @@ -26,7 +26,7 @@ Bugfixes | |||
| types requirement by `Synchon Mandal`_ (:gh:`339`) | |||
| - Remove extra dimension from masks warped via ANTs by `Synchon Mandal`_ | |||
| (:gh:`340`) | |||
|
|
|||
| - Add 'emomatching' task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_ (:gh:`370`) | |||
There was a problem hiding this comment.
This should now be in the docs/changes/newsfragments directory, in a file named 370.bugfix that has the following content:
Add ``'emomatching'`` task to :class:`DataladAOMICPIOP2` by `Leonard Sasse`_
fraimondo
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.