Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validation and better description for the offer_url attribute #464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ivansteinium
Copy link

Description

Added validation and better description for the offer_url attribute that the name and endpoint fields cannot be used alongside offer_url.

Fixes:
fixes #449

Type of change

<What type of a change is this? Please keep one or more relevant lines from below and delete the others.>

  • Change existing resource
  • Change docs

@hmlanigan hmlanigan added this to the 0.12.1 milestone Apr 22, 2024
@cderici cderici self-requested a review May 1, 2024 15:24
Copy link

@cderici cderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivansteinium Thanks for the change ❤️ generally looks good, but a couple of things are needed, please:

  • rebase the PR and resolve the conflicts,
  • the code part seems redundant, as the validation for the mutual exclusivity of offer_url, name and endpoint are already being checked in the ValidateConfig() for integrationResource.
  • fix broken tests (I assume this won't be needed after the extra validation code is removed).
  • provide QA steps in PR description, if there's no code added or functionality changed, then please state that in the QA steps as well.

Thanks again! After these are done we'll take over and give it another review and land it 👍

@hmlanigan hmlanigan added the state/decaying started a while ago and losing traction label Jun 6, 2024
@hmlanigan hmlanigan removed this from the 0.13.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state/decaying started a while ago and losing traction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs doesn't include an example of using offer_url
3 participants