-
Notifications
You must be signed in to change notification settings - Fork 16
Versions not supported by the base image #5
Comments
Hm, that is really strange, because I think all of these builds did work a while ago back... Did they delete these images? One of the major scenarios I want us to support is to make it easy to provide a repository that has replication code for scientific papers, and for that it is really quite crucial that one can specify a specific Julia version, and that such a version specifier will still work a couple years down the road. My gut feeling is that if the official Julia docker image is no longer willing to provide images with old Julia versions, then maybe we should just not base our stuff off the Julia base image and instead just put everything together ourselves here... I find the whole idea that they would actually delete images that folks might depend on pretty unsettling, TBH... But maybe I'm misunderstanding something? I also couldn't find any discussion of trace where such a decision to delete old images was taken... Maybe that would be the first step, to figure out what is actually going on with the official images. |
Ok, so actually I think they didn't delete these old images, right? So we should be all good and can continue to rely on them? Is the problem actually that your PR relied on some functionality that is not present in the older Julia base images? |
The reason the build failed is due to a change in the script copied to the Docker image. This change was made 4 days ago.(microsoft/vscode-dev-containers#779) The versions that failed to build were $ docker run --rm -it julia:1.1.0 cat /etc/debian_version
9.9
$ docker run --rm -it julia:1.1.1 cat /etc/debian_version
10.0
$ docker run --rm -it julia cat /etc/debian_version
10.8
In this way, the old Docker official images stops Debian updating, so it may not be possible to execute a script for the new Debian like this time. However, this time we can avoid the problem by setting the 7th argument of the script (now |
You may find it helpful to read The Docker official image |
I forgot to write one thing. $ docker pull ghcr.io/julia-vscode/julia-devcontainer@sha256:ade91ac748142ebb3dbfee6281fb1a59e75cc7b214a727b3023f4b91cd024199 Also, as you can see from the Docker official images, tags that are no longer updated will remain. |
Ok, so for now I turned that seventh argument to I think we need to think a bit more what these images here actually are meant to do and what the best way to maintain them is... My original idea had been that we would keep an image for each Julia version, and keep each of these images up-to-date. But that clearly is more difficult than I anticipated because the underlying Julia images are not all maintained... I guess there is also the question whether it is actually better for reproducibility if we update these images at all, after all if we update the Julia 1.3.0 image to a new OS version, that might also break things. So not sure... I think the options we have a probably:
I don't think we need to come to a conclusion quickly, so I'll leave this issue open for a while, I'd be interested to hear what folks think :) |
I should mention that support for other devcontainer images is described in this issue. |
I apologize that my PR(#3) has caused the image build to fail.
I had not checked to see if I could build on older versions.
https://github.com/julia-vscode/julia-devcontainer/runs/2103487996
It seems that the only supported versions of Julia Docker official image as of today are
1.0.5
, the latest version of1.0
, and1.5.3
, the latest version of1.5
.https://github.com/docker-library/docs/blob/master/julia/README.md
I think it would be appropriate to limit the images to only those versions (
1.0
,1.5
,1
,latest
) that are supported.And it is a good idea to list the supported versions in
devcontainer.json
like that,https://github.com/microsoft/vscode-dev-containers/blob/b16a7e4b86bb2e7796dcec902834d77431fe5563/containers/r/.devcontainer/devcontainer.json#L5
If you don't mind, I'd like to submit PRs for these changes.
The text was updated successfully, but these errors were encountered: