-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applier manager improvements #5062
Commits on Oct 1, 2024
-
The stacks don't need to be stored in the manager struct
The map is only ever used in the loop to create and remove stacks, so it doesn't need to be stored in the struct. This ensures that there can't be any racy concurrent accesses to it. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ba547ed - Browse repository at this point
Copy the full SHA ba547edView commit details -
Don't check for closed watch channels
The only reason these channels get closed is if the watcher itself gets closed. This happens only when the method returns, which in turn only happens when the context is done. In this case, the loop has already exited without a select on a potentially closed channel. So the branches that checked for closed channels were effectively unreachable during runtime. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for db5e0d2 - Browse repository at this point
Copy the full SHA db5e0d2View commit details -
Wait for goroutines to exit in applier manager
Rename cancelWatcher to stop and wait until the newly added stopped channel is closed. Also, add a stopped channel to each stack to do the same for each stack-specific goroutine. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 402c728 - Browse repository at this point
Copy the full SHA 402c728View commit details -
Improve logging in applier manager
Cancel the contexts with a cause. Add this cause to the log statements when exiting loops. Rename bundlePath to bundleDir to reflect the fact that it is a directory, not a file. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for edb105c - Browse repository at this point
Copy the full SHA edb105cView commit details -
Restart applier manager watch loop on errors
Exit the loop on error and restart it after a one-minute delay to allow it to recover in a new run. Also replace the bespoke retry loop for stacks with the Kubernetes client's wait package. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 404c6cf - Browse repository at this point
Copy the full SHA 404c6cfView commit details -
Remove unused applier field from applier manager
Seems to be a remnant from the past. Signed-off-by: Tom Wieczorek <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c2beea7 - Browse repository at this point
Copy the full SHA c2beea7View commit details
Commits on Oct 21, 2024
-
chore: add applier manager test
Signed-off-by: Ethan Mosbaugh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11b3197 - Browse repository at this point
Copy the full SHA 11b3197View commit details