build(deps): bump github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2 in /hack/tool #5157
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
Need to check the OS tests first. |
|
Still not working:
@kke Mind to have a look? |
|
This pull request has merge conflicts that need to be resolved. |
dependabot
bot
force-pushed
the
dependabot/go_modules/hack/tool/github.com/k0sproject/k0sctl-0.19.2
branch
from
7bab297
to
d8df62e
Compare
Bumps [github.com/k0sproject/k0sctl](https://github.com/k0sproject/k0sctl) from 0.19.0 to 0.19.2. - [Release notes](https://github.com/k0sproject/k0sctl/releases) - [Commits](k0sproject/k0sctl@v0.19.0...v0.19.2) --- updated-dependencies: - dependency-name: github.com/k0sproject/k0sctl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/hack/tool/github.com/k0sproject/k0sctl-0.19.2
branch
from
d8df62e
to
7f71323
Compare
|
All SANs manipulation was removed from k0sctl as k0s does it on its own. Looks like some of them were not redundant. |
|
It was made in k0sproject/k0sctl@fd0ba50
|
|
k0s does this: // Sans return the given SANS plus all local addresses and externalAddress if given
func (a *APISpec) Sans() []string {
sans, _ := iface.AllAddresses()
sans = append(sans, a.Address)
sans = append(sans, a.SANs...)
if a.ExternalAddress != "" {
sans = append(sans, a.ExternalAddress)
}
return stringslice.Unique(sans)
} |
|
Could it be that 23.22.x.x is not returned from sans = append(sans, a.Address)k0sctl sets this to the private address of the node or the public one if not set. |
|
Should k0sctl maybe default |
|
Adding the public address to SANs could make sense since it could be a NAT address not actually existing on the host. |
Bumps github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2.
Release notes
Sourced from github.com/k0sproject/k0sctl's releases.
Commits
081dfebFix k0s CPLB config parsing interface conversion panic (#776)0646847Use go1.23.2, update dependencies (#774)09cfd11Extract etcd membership check into a separate phase (#770)4c6450dMerge pull request #772 from k0sproject/validate-connection-vrrp-ipfd0ba50Remove all SANs manipulation as k0s does it on its own3f9f91dValidate worker connectivity to cluster-internal addresses6b9054bConsider k0s onlyBindToAddress option when building API URLsec2a1f9Fall back to CPLB virtual address in external API URLb8a2fd0Merge pull request #769 from k0sproject/modifiable-applyaction5bc7203Make Apply action phase list modifiable before Run()Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)