Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test which verifies traffic policies and firewall in services #10972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manuelbuil
Copy link
Contributor

@manuelbuil manuelbuil commented Oct 2, 2024

Proposed Changes

New e2e test to verify services externaltrafficpolicy, internaltrafficpolicy and loadBalancerSourceRanges

Types of Changes

New e2e test

Verification

Run go test

Testing

Linked Issues

User-Facing Change


Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner October 2, 2024 14:20
@manuelbuil manuelbuil force-pushed the addTestAdvanceFeatureServices branch 2 times, most recently from fbabd3b to bb73757 Compare October 3, 2024 11:12
@manuelbuil manuelbuil changed the title Add e2e test which verifies externaltrafficpolicy and internaltraffic policy Add e2e test which verifies traffic policies and firewall Oct 3, 2024
@manuelbuil manuelbuil changed the title Add e2e test which verifies traffic policies and firewall Add e2e test which verifies traffic policies and firewall in services Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.15%. Comparing base (6c6d87d) to head (2031570).
Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6c6d87d) and HEAD (2031570). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6c6d87d) HEAD (2031570)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10972      +/-   ##
==========================================
- Coverage   50.06%   44.15%   -5.91%     
==========================================
  Files         178      178              
  Lines       14801    14801              
==========================================
- Hits         7410     6536     -874     
- Misses       6044     7064    +1020     
+ Partials     1347     1201     -146     
Flag Coverage Δ
e2etests 36.47% <ø> (-9.80%) ⬇️
inttests 36.74% <ø> (ø)
unittests 13.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manuelbuil manuelbuil force-pushed the addTestAdvanceFeatureServices branch 2 times, most recently from 975da3f to bc30eee Compare October 3, 2024 15:17
thomasferrandiz
thomasferrandiz previously approved these changes Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants