Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Add Parametric Soft Exponential Unit (PSEU) activation layer #459

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

SriRangaTarun
Copy link
Contributor

Please make sure you've read and understood our contributing guidelines;
https://github.com/keras-team/keras-contrib/blob/master/CONTRIBUTING.md
-->

- What I did
See above

- How I did it

- How you can verify it
I added unit tests


This pull request fixes #issue_number_here

@SriRangaTarun
Copy link
Contributor Author

SriRangaTarun commented Feb 16, 2019

@RaphaelMeudec and @gabrieldemarmiesse This is the new PR for PSEU (a copy of the previous one). Here, I have merged master into my branch and made it compatible with tf.keras. Any other changes ?

@SriRangaTarun
Copy link
Contributor Author

SriRangaTarun commented Feb 16, 2019

@RaphaelMeudec and @gabrieldemarmiesse The build is now passing and the layer is tf.keras compatible. The ISRLU layer is also ready (build passing and tf.keras compatible)

Copy link
Contributor

@RaphaelMeudec RaphaelMeudec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SriRangaTarun Made some additional notes on the PR !

self.trainable = False

if is_tf_keras:
def alpha_initializer(self, input_shape, dtype='float32', partition_info=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partition_info is a useless arg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to separate is_tf_keras case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaphaelMeudec The initializer does not work in tf.keras without the partition_info argument.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use **kwargs to have only one declaration.

Copy link
Contributor Author

@SriRangaTarun SriRangaTarun Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrieldemarmiesse Added **kwargs

@SriRangaTarun
Copy link
Contributor Author

@fchollet It would be great if you or someone else from your team can review this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants