Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for the Torch distributed multi-GPU example and guide. #431

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fixes for the Torch distributed multi-GPU example and guide. #431

merged 1 commit into from
Jul 7, 2023

Conversation

hertschuh
Copy link
Collaborator

Using "localhost" removes the need for putting the actual hostname.

nkovela1
nkovela1 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@nkovela1 nkovela1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the adjustment, Fabien.

fchollet
fchollet approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@fchollet fchollet merged commit 599088f into main Jul 7, 2023
5 checks passed
@hertschuh hertschuh deleted the dist_torch_fixes branch July 7, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@nkovela1 nkovela1 nkovela1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hertschuh @fchollet @nkovela1