Optimizer torch optimizer performance #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifeng-jin
commented
Jul 17, 2023
| @@ -21,7 +21,7 @@ def test_config(self): | |||
| def test_single_step(self): | |||
| optimizer = SGD(learning_rate=0.5) | |||
| self.assertEqual(len(optimizer.variables), 2) | |||
| grads = np.array([1.0, 6.0, 7.0, 2.0]) | |||
There was a problem hiding this comment.
Do we need to support np.array for apply_gradients? @fchollet
haifeng-jin
changed the title
adi-kmt
pushed a commit
to adi-kmt/keras-core
that referenced
this pull request
Jul 21, 2023
* add torch optimizers * addressing comments --------- Co-authored-by: Haifeng Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented SGD optimizer for torch backend with the torch parallel functions.
It process all the variables in parallel.
Before this PR, if executed eagerly, the variables would be updated in series.