Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete missing docstrings in keras-core/ops/core.py #494

Merged
merged 7 commits into from
Jul 15, 2023
Merged

Complete missing docstrings in keras-core/ops/core.py #494

merged 7 commits into from
Jul 15, 2023

Conversation

Frightera
Copy link
Contributor

Most of the py files have the functions defined in that module at top:

Example:

"""
scatter
scatter_update
slice
slice_update
while_loop
stop_gradient
shape
cast
convert_to_tensor
convert_to_numpy
"""

Should they be removed?

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras_core/ops/core.py Outdated Show resolved Hide resolved
keras_core/ops/core.py Outdated Show resolved Hide resolved
keras_core/ops/core.py Outdated Show resolved Hide resolved
keras_core/ops/core.py Outdated Show resolved Hide resolved
@Frightera
Copy link
Contributor Author

@fchollet Should be fine now, I got the style now 😎

@Frightera Frightera requested a review from fchollet July 15, 2023 22:06
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

keras_core/ops/core.py Outdated Show resolved Hide resolved
@fchollet
Copy link
Member

Also if there's a single example, use Example: as the section title

@Frightera Frightera requested a review from fchollet July 15, 2023 23:31
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fchollet fchollet merged commit cace5e7 into keras-team:main Jul 15, 2023
5 checks passed
@Frightera Frightera deleted the docstrings_core branch July 16, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants