Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docstrings to Keras Core ops in numpy.py file #507

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

sukhdeepg
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Jul 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

# Broadcast input shapes to a unified shape.
# Convert to list for mutability.
"""Broadcast input shapes to a unified shape.
Convert to list for mutability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line break above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I've added blank line above "convert to list ..."

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sukhdeepg
Copy link
Contributor Author

sukhdeepg commented Jul 17, 2023

could you please give approval for workflow? I'm getting this message
Screenshot 2023-07-17 at 8 04 50 AM

I just merged code from main into my branch.

@fchollet fchollet merged commit f2c16f7 into keras-team:main Jul 17, 2023
4 of 5 checks passed
@sukhdeepg sukhdeepg deleted the docstrings-update branch July 17, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants