Added docstring ops/image/resize #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jul 16, 2023
|
|
||
| >>> x = np.random.random((2, 4, 4, 3)) # batch of 2 RGB images | ||
| >>> y = keras_core.ops.image.resize(x, (2, 2)) | ||
| >>> y.shape |
There was a problem hiding this comment.
That depends on the backend, if it is TensorFlow it'll output TensorShape etc. Guess it is best to remove y.shape then?
There was a problem hiding this comment.
Is it OK to put symbolic outputs here, like: (2, 2, 2, 3) etc?
There was a problem hiding this comment.
Yes, it should just be indicative.
|
Thank you for your comments @fchollet, should be good to go now 😎 Edit: Can you also check keras-team/keras#18442? |
|
Hi @fchollet, any update on this? Looks like I can't re-run the checks 😢 |
adi-kmt
pushed a commit
to adi-kmt/keras-core
that referenced
this pull request
Jul 21, 2023
* Image resize docstring added * Unindent examples * Remove tf tensor reference * Update the resize docstring * Add default arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the docstring for
keras_core.ops.image.resize