-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Numpy Backend #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
…as-core into aritra-np-backend OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR -- it looks good overall, what test failures do you see?
Every test realted to the Trainer fails (as NumPy should not have a trainer module). It would be great if someone from the team could help me understand whether the failing tests should be skipped or I should rather work on them to make them pass. |
I can take a look, and will try to help |
Normally every test that is "supposed" to fail should fail with a |
Todos:
|
@AakashKumarNain if you want to take up the |
@fchollet would it be okay if I introduced the numpy test in the GitHub Actions as well? And to do that I think I would just need to add keras-core/.github/workflows/actions.yml Line 14 in ce9b511
Am I correct here? |
@fchollet some pointers:
|
It is a known issue that resizing with PIL though most correct, is impossible to reproduce in |
Let's carry on in the other PR! |
This PR will add
NumPy
backend toKerasCore