Increase test coverage + Fix save_model_to_hdf5 + Improve is_remote_path + Fix is_remote_path

[Faisal-Alsrheed]

This PR aims to increase the robustness of the codebase by improving test coverage, fixing existing functions, and adding new tests to validate the changes made.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +7.04% 🎉

Comparison is base (74a4e7f) 76.78% compared to head (021068b) 83.83%.
Report is 56 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   76.78%   83.83%   +7.04%     
==========================================
  Files         329      318      -11     
  Lines       31431    28731    -2700     
  Branches     6113     5486     -627     
==========================================
- Hits        24134    24086      -48     
+ Misses       5726     3140    -2586     
+ Partials     1571     1505      -66     

Flag	Coverage Δ
keras_core	83.73% <100.00%> (+7.04%)	⬆️
keras_core-jax	67.17% <100.00%> (?)
keras_core-numpy	60.64% <100.00%> (?)
keras_core-tensorflow	66.97% <100.00%> (?)
keras_core-torch	69.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
keras_core/utils/file_utils.py	66.06% <100.00%> (+3.61%)	⬆️

... and 54 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fchollet]

Thanks for the PR!

[fchollet]

Which ones of these work with gfile? Since we use gfile for remote paths, we should only match the paths for which it will work (otherwise using local accessors which will raise an error is fine).

[Faisal-Alsrheed]

WIP

[Faisal-Alsrheed]

Hello @fchollet,

I've refined the is_remote_path function to only recognize gs:// and hdfs:// based on gfile capabilities.

I've also added a warning message when encountering an unrecognized remote path. This provides immediate feedback to developers, helping them quickly identify and address potential issues.

Would appreciate your feedback on this approach.

[Faisal-Alsrheed]

def is_remote_path(filepath):
    filepath_str = str(filepath).strip()
    supported_patterns = [re.compile(r"^(gs|hdfs)://.*$", re.IGNORECASE)]

    for pattern in supported_patterns:
        if pattern.match(filepath_str):
            return True

    # Log or print the error message without raising an exception
    warning_msg = (
        f"Warning: The path '{filepath_str}' is not recognized as a "
        f"supported remote path by gfile. Supported paths are: "
        f"{', '.join(['gs://', 'hdfs://'])}"
    )
    print(warning_msg)

    return False

[fchollet]

LGTM -- thanks!

[Faisal-Alsrheed]

@fchollet
Thank you for your feedback.
I am still working on your comments.
I will will let you know once it is ready

[fchollet]

Thank you -- great work!