Improve error handling for missing TensorFlow dependency in KerasCV #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innat
reviewed
May 1, 2024
| raise ImportError( | ||
| "To use KerasCV, please install TensorFlow: `pip install tensorflow`. " | ||
| "The TensorFlow package is required for data preprocessing with any backend." | ||
| ) |
There was a problem hiding this comment.
Will keras-cv always depend on tensorflow for data processing layers?
smitlg
reviewed
May 16, 2024
| @@ -46,7 +46,14 @@ | |||
| from tensorflow import split # noqa: F403, F401 | |||
There was a problem hiding this comment.
These imports will also fail in case tensorflow is not installed. Making this same change across all the files makes it more hard to maintain. Instead, this should be wrapped around in some module like keras_cv/utils/conditional_imports.py and import tensorflow from this wrapper.
divyashreepathihalli
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: user doesn't have
tensorflowinstalled and doesn't expect to get error as they're usingpytorchbackend.