Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobilenet Update and conversion #1908

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Mobilenet Update and conversion #1908

wants to merge 15 commits into from
+1,109 −606

Conversation

ushareng
Copy link
Collaborator

@ushareng ushareng commented Oct 4, 2024

Updating the implementation of mobilenet as per torch, and then will add the timm conversion script to port weights from hf

@ushareng ushareng marked this pull request as draft October 4, 2024 14:59
@ushareng ushareng marked this pull request as ready for review October 7, 2024 17:29
@divyashreepathihalli
Copy link
Collaborator

Thanks for the PR @ushareng!!
The port in KerasHub support V2 and v3 correct?
we might want to add support for timm/mobilenetv3_large_100.ra_in1k and timm/mobilenetv2_100.ra_in1k

Here are the checkpoints on HF for classic models - https://huggingface.co/collections/timm/timm-takes-on-the-classics-655ce63dcaa21067cd7d3f4c

@divyashreepathihalli
Copy link
Collaborator

Hi @ushareng Thanks for the PR - I quickly tried out the conversion and I am seeing this error -
image

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Oct 7, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Oct 7, 2024
@ushareng ushareng marked this pull request as draft October 7, 2024 20:07
@ushareng ushareng marked this pull request as ready for review October 9, 2024 17:08
@divyashreepathihalli
Copy link
Collaborator

Hi @ushareng you might want to run shell/api_gen.sh at root.

@divyashreepathihalli divyashreepathihalli added the kokoro:force-run Runs Tests on GPU label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyashreepathihalli divyashreepathihalli Awaiting requested review from divyashreepathihalli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
kokoro:force-run Runs Tests on GPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ushareng @divyashreepathihalli @kokoro-team