Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout map for Llama #1923

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Layout map for Llama #1923

merged 7 commits into from
Oct 16, 2024
+235 −10

Conversation

martin-gorner
Copy link
Contributor

Added default layout map for Llama

SamanehSaadat
SamanehSaadat reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Martin!
Just some minor comments!

keras_hub/src/models/llama/llama_backbone.py Show resolved Hide resolved
keras_hub/src/models/llama/llama_backbone_test.py Outdated Show resolved Hide resolved
keras_hub/src/models/llama/llama_backbone_test.py Outdated Show resolved Hide resolved
keras_hub/src/models/llama/llama_backbone.py Outdated Show resolved Hide resolved
keras_hub/src/tokenizers/byte_pair_tokenizer_test.py Outdated Show resolved Hide resolved
@SamanehSaadat
Copy link
Member

@martin-gorner I didn't know that I should click a button to allow the IC tests to run (it's my first time reviewing external contributions :) ).
They are running now and it seems like there is a formatting error and ./shell/format.sh should be run to fix.

@martin-gorner
Copy link
Contributor Author

the formatting error should be gone as well

SamanehSaadat
SamanehSaadat approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@SamanehSaadat SamanehSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Martin!

@SamanehSaadat SamanehSaadat merged commit 8a77bbd into keras-team:master Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamanehSaadat SamanehSaadat SamanehSaadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-gorner @SamanehSaadat