Update encoding in movielens_recommendations_transformers.py #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present the example tutorial raising the UnicodeDecodeError at the code movies=pd.read_csv() UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 3114: invalid continuation byte Hence adding the encoding='latin-1' to the movies=pd.read_csv(...,encoding='latin-1') will get rid of this error. Hence I proposed this code change for review and approval.
haifeng-jin
requested changes
Jun 22, 2023
Done the suggested changes
Updated encoding in .ipynb file also as requested
Updated encoding in .md file as requested.
|
Please format the code using |
Done the changes as suggested for black format
Corrected lint errors
Removed white spaces and done required changes for black format.
|
All the checks passed now. May please review. |
SuryanarayanaY
added
keras-team-review-pending
and removed
stat:awaiting response from contributor
labels
sachinprasadhs
added
stat:awaiting keras-eng
and removed
keras-team-review-pending
labels
|
Hi @haifeng-jin, Can you please review this PR ? Thank you! |
1 similar comment
|
Hi @haifeng-jin, Can you please review this PR ? Thank you! |
haifeng-jin
reviewed
Nov 28, 2023
|
Hi @SuryanarayanaY Can you please check @haifeng-jin's comments and keep us posted ? Thank you! |
|
Hi @SuryanarayanaY Any update on this PR? Please. Thank you! |
|
Closing the PR, since the tutorial is already migrated and working fine with the Keras 3 using ISO encoding here https://keras.io/examples/structured_data/movielens_recommendations_transformers/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the example tutorial raising the UnicodeDecodeError at
movies=pd.read_csv()UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 3114: invalid continuation byteHence adding the
encoding='latin-1'to themovies=pd.read_csv(...,encoding='latin-1')will get rid of this error.Hence I proposed this code change for review and approval.
Attaching gist for reference to check the error and solution that works fine.