-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply backend.result_type
to absolute
, argmax
, argmin
, argsort
, ceil
, clip
and dot
#18548
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #18548 +/- ##
==========================================
- Coverage 77.67% 71.97% -5.71%
==========================================
Files 334 334
Lines 32302 32354 +52
Branches 6297 6308 +11
==========================================
- Hits 25092 23287 -1805
- Misses 5631 7578 +1947
+ Partials 1579 1489 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Some tests have failed and I believe the root cause is the new release of torch 2.1.0. EDITED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Great work!
Followed by #18482 and #18534
The corresponding unit tests have also been added.
I choose these ops that are more commonly used in the codebase.
In
ceil
, int64 input will become float64 output but I have changed it tobackend.floatx()
.The principles in my mind, which are derived from the previous discussion:
backend.floatx()