the dynamic has a result, but the static inference shape reports an error #20242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20242 +/- ##
==========================================
- Coverage 79.38% 79.37% -0.02%
==========================================
Files 501 501
Lines 47483 47503 +20
Branches 8718 8725 +7
==========================================
+ Hits 37694 37705 +11
- Misses 8025 8033 +8
- Partials 1764 1765 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fchollet
reviewed
Sep 9, 2024
| padding, | ||
| data_format, | ||
| ).symbolic_call(inputs) | ||
| return operation_utils.compute_pooling_output_shape( |
There was a problem hiding this comment.
This is incorrect, the symbolic call should return a KerasTensor instance.
There was a problem hiding this comment.
@fchollet - Thanks for update. Let me have a resolve it and commit again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static and dynamic input to AveragePooling2D should show same result and error. Fixes #20218