Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #779: Fix pip build
Imported from GitHub PR #779
As discussed in #776
I tried but actually run into the issue that layers/experimental cannot be used as a build target, as the builds inside experimental require layers -> circular deps. The other folders in
layers
circumvent this by specifying only the specific build targets.Instead of changing the logic (i.e. is experimental meant to be dev-built only?), I did what the error advertised and added it to the ignored builds, as it's seemingly not made to be built
Copybara import of the project:
--
9d3bb64 by Jonas Eschle [email protected]:
docs: update CONTRIBUTING.md with new name tf-keras
(cherry picked from commit fb79960)
--
7bd7b3d by Jonas Eschle [email protected]:
fix: python build ignore experimental due to circular refs
(cherry picked from commit 9b349e3)
Merging this change closes #779
FUTURE_COPYBARA_INTEGRATE_REVIEW=#779 from jonas-eschle:fix_pip_build 7bd7b3d