-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comma delimited info string language #328
base: main
Are you sure you want to change the base?
Comma delimited info string language #328
Conversation
```\n\ | ||
", | ||
"\ | ||
<pre style=\"background-color:#2b303b;\"><code class=\"language-rust,ignore\">\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still has class="language-rust,ignore"
, so it wouldn't match anything looking for the class language-rust
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now that this doesn't fit your use case. Changing that would differ from cmark-gfm
's output, but I should be able to add that functionality behind a parse option instead
I'll work on handling that today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does match GitHub's behavior though, so maybe cmark-gfm
has a bug 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that GitHub uses the full-info-string
option (which gives the full info string, not just the first word) and then parses the language out themselves. That's what we do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure on how to proceed, so I'll just be awaiting more definitive feedback
Fixes #246
Changes the syntect plugin to split off any text following a comma from the language tag to match what is supported by rustdoc and GitHub. This now accepts
```rust,no_run
as Rust code