Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.js #415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update config.js #415

wants to merge 1 commit into from

Conversation

donni106
Copy link

@donni106 donni106 commented Nov 1, 2021

No description provided.

@adewes
Copy link
Contributor

adewes commented Nov 9, 2021

Thanks for the PR! What's wrong with the "are" in your opinion?

@donni106
Copy link
Author

donni106 commented Nov 9, 2021

Thanks for the PR! What's wrong with the "are" in your opinion?

i read it as "Setting this to true will render the descriptions of the consent modal and consent notice are HTML." and thought of a weird "something will render are HTML" resulting in my change to "Setting this to true will render the descriptions of the consent modal and consent notice as HTML."

did i get something wrong?

i should have added that thought in the PR description.

@donni106
Copy link
Author

@adewes what about this PR?

@donni106
Copy link
Author

donni106 commented May 2, 2023

@adewes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants