Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpcompatibility and codesniffer #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smoucka
Copy link
Contributor

@smoucka smoucka commented Nov 18, 2024

Description

Updating dev dependencies to take advantage of recent features/changes. Addresses ECOS-4387

Both PHPCompatibility and PHPCodesniffer have new maintainers.

PHPCodesniffer is actively releasing new versions - we're updating to take advantage of the newest features. The recently forked repo under current maintenance is available under the same packagist entry squizlabs/php_codesniffer 🙌

PHPCompatibility hasn't released a new version but the develop branch is getting new php 8.x sniffs and the branch is available. Let's use it to get access to those 8.x sniffs.

Manual Testing Steps

  1. Made incompatible change locally - caught by pre-commit
    image

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@smoucka smoucka requested a review from a team as a code owner November 18, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants